Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add for ibc-rs ChainId encoding and decoding component #525

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add for ibc-rs ChainId encoding and decoding component #525

merged 2 commits into from
Jan 15, 2025

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jan 15, 2025

Description

This PR adds a component a EncodeChainIdField component used for encoding and decoding ibc-rs type ChainId

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from soareschen January 15, 2025 13:19
@ljoss17 ljoss17 mentioned this pull request Jan 15, 2025
Merged
3 tasks
@ljoss17 ljoss17 merged commit 9dd5e35 into main Jan 15, 2025
10 checks passed
@ljoss17 ljoss17 deleted the luca_joss/add-chain-id-encoding-decoding branch January 15, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljoss17 @soareschen