added cache aproach to registrant api response for domains #2411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So what am I doing here?
Here I actually cached the response from the registrant api to speed up the response in case of a large number of domains. I do not have the opportunity to test this on staging, I can only be based on the experience of the dev environment
So, before that, 3000 domains were rendered in the registrant center for about 43 seconds, after the changes, now this number of domains is rendered for 7 seconds.
Also in the development environment, I created a
tmp/cache.txt
file with therails dev:cache
command. Also in development.rb I made the following valueconfig.cache_store = :redis_cache_store
if on staging the result is also good for a large number of domains, then this approach can be sent to production.
Do you have any opinions, additions, criticism?