feat: eslint v9 & flat config setup #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 870e09f The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
imCorfitz
reviewed
May 28, 2024
apps/marketing/eslint.config.js
Outdated
imCorfitz
reviewed
May 28, 2024
There was a problem hiding this comment.
Have all of these tailwind updates been automatically made by lint --fix?
imCorfitz
reviewed
May 28, 2024
| @@ -29,13 +29,13 @@ const RadioGroupItem = React.forwardRef< | |||
| <RadioGroupPrimitive.Item | |||
| ref={ref} | |||
| className={cn( | |||
| 'aspect-square h-4 w-4 rounded-full border border-primary text-primary shadow focus:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50', | |||
| 'aspect-[1_/_1] size-4 rounded-full border border-primary text-primary shadow focus:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50', | |||
There was a problem hiding this comment.
odd that aspect-square was changed to aspect-[1_/_1] in this case 🤔
There was a problem hiding this comment.
for some reason the eslint plugin complains about this that it's an invalid tailwind class name even though it does exist so i went around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.