-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: posthog #70
feat: posthog #70
Conversation
- Update .env.example - Add Posthog to web - Add Posthog to marketing - Update cspell config
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! just some conflicts to resolve and I think we can merge it!
- Add dependencies - Modify Posthog Astro Component - Add Posthog to Documentation
experimental__runtimeEnv: { | ||
NODE_ENV: process.env.NODE_ENV, | ||
// eslint-disable-next-line turbo/no-undeclared-env-vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can disable this rule entirely for this package in the eslint.config.js
file of packages/env
because it won't ever work as that the turbo plugin wouldn't be able to see the turbo.json
files of the apps, where these env vars are passed through.
Add this to packages/env/eslint.config.js
:
import { configs, defineConfig } from '@orbitkit/eslint';
export default defineConfig(...configs.base, {
rules: {
// We disable this rule in this package because turbo can't find the turbo.json files of the apps to know that we are actually passing through env vars there.
'turbo/no-undeclared-env-vars': 'off',
},
});
Then you can remove the eslint-disable-next-line
comments from this file.
Actually i'll merge and do that change quickly. |
Note: I am having an issue with
PostHog.astro
, the typechecker is working even though i am usingis:inline
flagcloses #6