Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: posthog #70

Merged
merged 6 commits into from
Jun 11, 2024
Merged

feat: posthog #70

merged 6 commits into from
Jun 11, 2024

Conversation

ahmedhesham6
Copy link
Contributor

  • Update .env.example
  • Add Posthog to web
  • Add Posthog to marketing
  • Update cspell config

Note: I am having an issue with PostHog.astro, the typechecker is working even though i am using is:inline flag

closes #6

- Update .env.example
- Add Posthog to web
- Add Posthog to marketing
- Update cspell config
Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: 012ce2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ahmedhesham6 ahmedhesham6 requested a review from ixahmedxi June 8, 2024 11:01
Copy link
Owner

@ixahmedxi ixahmedxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! just some conflicts to resolve and I think we can merge it!

@ahmedhesham6 ahmedhesham6 requested a review from ixahmedxi June 10, 2024 22:40
- Add dependencies
- Modify Posthog Astro Component
- Add Posthog to Documentation
- disable linting rule since its applied in web/turbo.json
experimental__runtimeEnv: {
NODE_ENV: process.env.NODE_ENV,
// eslint-disable-next-line turbo/no-undeclared-env-vars
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can disable this rule entirely for this package in the eslint.config.js file of packages/env because it won't ever work as that the turbo plugin wouldn't be able to see the turbo.json files of the apps, where these env vars are passed through.

Add this to packages/env/eslint.config.js:

import { configs, defineConfig } from '@orbitkit/eslint';

export default defineConfig(...configs.base, {
  rules: {
    // We disable this rule in this package because turbo can't find the turbo.json files of the apps to know that we are actually passing through env vars there.
    'turbo/no-undeclared-env-vars': 'off',
  },
});

Then you can remove the eslint-disable-next-line comments from this file.

@ixahmedxi
Copy link
Owner

Actually i'll merge and do that change quickly.

@ixahmedxi ixahmedxi merged commit bb11efc into ixahmedxi:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posthog integration
4 participants