Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: flight refactors #83

Merged
merged 6 commits into from
Jun 16, 2024
Merged

refactor: flight refactors #83

merged 6 commits into from
Jun 16, 2024

Conversation

ixahmedxi
Copy link
Owner

@ixahmedxi ixahmedxi commented Jun 16, 2024

This PR aims to do the following:

  • Switches the bundler used in the monorepo for the ui package from tsup to vite.
  • Renames the AUTH_GOOGLE_CODE_VERIFIER env var to AUTH_SECRET that way we can use it for more providers.
  • More elaborative .env.example file.
  • Splits the t3-env files between server and client for the web app, this adds an extra level of security because then this way, the server env variable names are not exposed to the client, also avoids a few issues here and there that i've seen before.

This commit brings the following changes:
- Removes `tsup` from the monorepo.
- Introduces a new `build` config preset in the `vite` package.
- Uses that `build` config preset in the `ui` package to build/bundle it
  instead of `tsup`.
Copy link

changeset-bot bot commented Jun 16, 2024

🦋 Changeset detected

Latest commit: 5b558c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@orbitkit/eslint Patch
@orbitkit/vite Patch
@orbitkit/utils Patch
@orbitkit/auth Patch
@orbitkit/env Patch
@orbitkit/ui Patch
@orbitkit/docs Patch
@orbitkit/web Patch
@orbitkit/marketing Patch
@orbitkit/api Patch
@orbitkit/assets Patch
@orbitkit/storybook Patch
@orbitkit/tailwind Patch
@orbitkit/tsconfig Patch
@orbitkit/core Patch
@orbitkit/db Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ixahmedxi ixahmedxi requested a review from imCorfitz June 16, 2024 12:22
@ixahmedxi ixahmedxi self-assigned this Jun 16, 2024
Copy link
Collaborator

@imCorfitz imCorfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful! Despite the many vite dependencies, I feel it makes a lot more sense now. Fewer hacks - more simplicity. Lovely!

@ixahmedxi ixahmedxi merged commit e0c4bfd into main Jun 16, 2024
7 checks passed
@ixahmedxi ixahmedxi deleted the ahmed/flight-refactors branch June 16, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants