feat: untangle quartz from local configs in least amount of changes #1730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the current setup where people have to fork or at least clone quartz this changes nothing - but it allows you to install quartz as a devDependency via npm and have it actually work.
One real change is switch from
.quartz-cache
tonode_modules/.cache/quartz
for transpilation results, this is an artifact from my previous attempts, I guess with this one I can change it back - butnode_modules/.cache
feels more better imo idk.edit: OTOH if you want to have quartz be a completely separate binary (which this also enables I think), having it create a node_modules folder is weird, so I made a quick hack for that for now.
Example:
Notice how I used my branch in the
npm i
line, ideally it'd benpm i quartz@jackyzha0/quartz
, or maybe we can somehow get the quartz package on npm and it'll just benpm i quartz
.In the latter case
npx quartz build
will literally just work without a local npm package at all?.Having some support for components and plugins being in separate npm packages instead of people copying code around is not out of the picture with this too btw.
Closes #502