Delete gRPC MetricsQueryService, metricsquery.proto and related code #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:breaking-change
yurishkuro
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6616 +/- ##
==========================================
- Coverage 96.03% 96.01% -0.03%
==========================================
Files 365 365
Lines 20767 20654 -113
==========================================
- Hits 19944 19831 -113
Misses 626 626
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mahadzaryab1
approved these changes
Jan 26, 2025
ekefan
pushed a commit
to ekefan/jaeger
that referenced
this pull request
Jan 26, 2025
…aegertracing#6616) ## Which problem is this PR solving? - No code in Jaeger was dependent on having a gRPC endpoint for reading metrics. UI's Monitor tab uses JSON endpoint. - This code is just a pass-through proxy to the underlying metrics storage with which we communicate using OpenMetrics API. ## Description of the changes - Delete unnecessary code and proto-gen types. - 🛑 This is a breaking change: the gRPC `MetricsQueryService` endpoint is removed. ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
MetricsQueryServiceendpoint is removed.How was this change tested?