Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FormValidation check when overwriting scopes when using the OicServerWellKnownConfiguration #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eva-mueller-coremedia
Copy link
Contributor

The field name in config.jelly for OicServerWellKnownConfiguration is scopesOverride not overrideScopes.
This PR aligns the Java method.

Testing done

This change has been tested by unit tests as well as manual local testing with mvn clean hpi:run.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.04%. Comparing base (41f98d9) to head (d6a5398).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #507      +/-   ##
============================================
+ Coverage     71.73%   72.04%   +0.30%     
- Complexity      222      235      +13     
============================================
  Files            17       18       +1     
  Lines          1033     1073      +40     
  Branches        148      149       +1     
============================================
+ Hits            741      773      +32     
- Misses          201      207       +6     
- Partials         91       93       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

when using the OicServerWellKnownConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant