Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some smaller housekeeping #509

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

eva-mueller-coremedia
Copy link
Contributor

When implementing #480 I git aware of some things which can be cleaned up like

  • Typos
  • Unused methods
  • Simplifications
  • JavaDoc alignments
  • Some additional tests

Testing done

Only covered by unit tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.74%. Comparing base (41f98d9) to head (a8a876a).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 44.44% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #509      +/-   ##
============================================
+ Coverage     71.73%   72.74%   +1.01%     
- Complexity      222      236      +14     
============================================
  Files            17       18       +1     
  Lines          1033     1064      +31     
  Branches        148      147       -1     
============================================
+ Hits            741      774      +33     
  Misses          201      201              
+ Partials         91       89       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant