Skip to content

Commit

Permalink
ThrottleQueueTaskDispatcher.java : shift logging priorities for less …
Browse files Browse the repository at this point in the history
…spam in FINE level
  • Loading branch information
jimklimov committed Feb 10, 2020
1 parent 3cadb3a commit 63af186
Showing 1 changed file with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ private boolean isAnotherBuildWithSameParametersRunningOnNode(Node node, Queue.I
List<ParameterValue> itemParams = getParametersFromQueueItem(item);

if (paramsToCompare.size() > 0) {
LOGGER.log(Level.FINE, "filter itemParams " + itemParams +
LOGGER.log(Level.FINER, "filter itemParams " + itemParams +
" (from queue) to only pick up to " + paramsToCompare.size() +
": " + paramsToCompare + " (from throttle config)");
itemParams = doFilterParams(paramsToCompare, itemParams);
Expand All @@ -356,7 +356,7 @@ private boolean isAnotherBuildWithSameParametersRunningOnNode(Node node, Queue.I
parentTask.getOwnerTask().getName().equals(item.task.getName())) {
List<ParameterValue> executingUnitParams = getParametersFromWorkUnit(exec.getCurrentWorkUnit());

LOGGER.log(Level.FINE, "filter executingUnitParams" +
LOGGER.log(Level.FINER, "filter executingUnitParams" +
" on " + computer.getDisplayName() + "#" + exec.getNumber() +
" in build (" + exec.getCurrentWorkUnit() + ") from original " +
executingUnitParams + " to only pick up to " +
Expand Down Expand Up @@ -391,27 +391,27 @@ private boolean isAnotherBuildWithSameParametersRunningOnNode(Node node, Queue.I
*/
private List<ParameterValue> doFilterParams(List<String> paramsToCompare, List<ParameterValue> OriginalParams) {
if (paramsToCompare.isEmpty()) {
LOGGER.log(Level.FINE, "doFilterParams(): paramsToCompare.isEmpty() => return OriginalParams");
LOGGER.log(Level.FINEST, "paramsToCompare.isEmpty() => return OriginalParams");
return OriginalParams;
}

List<ParameterValue> newParams = new ArrayList<ParameterValue>();
LOGGER.log(Level.FINE, "doFilterParams(): filtering by paramsToCompare = " + paramsToCompare);
LOGGER.log(Level.FINEST, "filtering by paramsToCompare = " + paramsToCompare);

for (ParameterValue p : OriginalParams) {
LOGGER.log(Level.FINE, "doFilterParams(): checking if original " +
LOGGER.log(Level.FINEST, "checking if original " +
p.getName() + " is on our list of paramsToCompare?.." );
if (paramsToCompare.contains(p.getName())) {
LOGGER.log(Level.FINE, "doFilterParams(): we have a hit in OriginalParams: " + p);
LOGGER.log(Level.FINEST, "we have a hit in OriginalParams: " + p);
newParams.add(p);
}
}
if (newParams.size() == 0 ) {
LOGGER.log(Level.WARNING, "doFilterParams(): Error selecting params," +
LOGGER.log(Level.WARNING, "Error selecting params," +
" got no hits of " + paramsToCompare + " in " + OriginalParams +
" : is the job configuration valid?");
} else if (newParams.size() < paramsToCompare.size() ) {
LOGGER.log(Level.WARNING, "doFilterParams(): Error selecting params," +
LOGGER.log(Level.WARNING, "Error selecting params," +
" not all of " + paramsToCompare + " were present in " + OriginalParams +
" : is the job configuration valid?");
}
Expand Down

0 comments on commit 63af186

Please sign in to comment.