Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-12093 - Allow per-project & category throttling on the same job #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gcummings
Copy link

Hi,

Please review and provide feedback.
Updated to always throttle on project settings, then optionally throttle by category.
Per existing behaviour, if project settings are 0, then no throttling occurs by project.

Other options could be

  1. add new radio box to specify throttle by both project and category.
  2. rework UI to have checkboxes to enable 'by project' and 'by category' independently so you can select both.

thanks
Geoff

Updated to always throttle on project settings, then optionally throttle
on category settings
@cloudbees-pull-request-builder

plugins » throttle-concurrent-builds-plugin #36 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev
Copy link
Member

I would prefer an extension point like ThrottleCategoryProvider (JENKINS-23558). BTW, this feature request is quite hot, so it makes sense to add this feature.

My proposals:

  • For the sake of backward compatibility set individual values to 0 if the category-based mode is checked. Use readResolve() for this purpose
  • Update help entries and describe the behavior

@raags
Copy link

raags commented Oct 20, 2017

This would be useful for us to apply both project and category level throttling. @oleg-nenashev @gcummings would you be able to resolve the conflicts and help merge this PR?

@timotei
Copy link

timotei commented Jul 23, 2024

@basil would there be availability to merge this PR if the conflicts are solved? We'd need something like this as well.

@basil
Copy link
Member

basil commented Jul 23, 2024

I'm not really maintaining this plugin anymore, you are free to adopt it as described in https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants