Several improvements #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelvigee
changed the title
| "description": "Silex i18n routing service provider.", | ||
| "keywords": ["silex", "i18n routing"], | ||
| "license": "MIT", | ||
| "require": { | ||
| "silex/silex": "~2.0@dev", | ||
| "silex/silex": "~1.0@dev", |
There was a problem hiding this comment.
There is another branch https://github.com/jenyak/I18nRoutingServiceProvider/tree/1.0 for support silex 1
|
@thegeekrv can you also add test for |
|
Sorry I did a mistake by committing the name change. |
This reverts commit 3541c2a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project, I had to generate every URLs localized, and also the non-localised default locale URL.
I think it's better to let the user a free choice on this point.
To set the option :
$app['i18n_routing.allow_localized_default'] = true;Let's say I have french and english languages enable.
With the option set to false, this will result in the following generated URLs :
/fr/test/en/testWith the option set to true, this will result in the following generated URLs :
/test/fr/test/en/test