Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12723 fix file:/ uris on windows for osgi #12728

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

janbartel
Copy link
Contributor

Fixes #12723

This PR restores the fixing of file:/ urls for osgi urls that was removed as part of #11577.

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider this the minimum fix. sure.

joakime
joakime previously approved these changes Jan 22, 2025
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Let me make this an actual approval.

@janbartel janbartel requested a review from gregw January 25, 2025 15:17
@janbartel janbartel requested review from gregw and joakime January 28, 2025 09:16
@janbartel janbartel merged commit 413a15d into jetty-12.0.x Jan 29, 2025
10 checks passed
@janbartel janbartel deleted the jetty-12.0.x-12723-fix-osgi-uris-windows branch January 29, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Only on Windows: Failed startup of context oeje8w.WebAppContext
3 participants