[jfrog-platform] tolerations on pre-upgrade-hook job #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@gpongelli This will be part of next minor release of platform ( after artifactory 7.104.x release) |
Hi @chukka thanks, could you plan to look for and eventually fix the absence of tolerations, affinity and anti-affinity for all the pods and jobs jfrog schedules on normal usage and while doing upgrade ? |
|
@gpongelli Request you to raise a PR for other ehnacements , will be happy to review and take them |
chukka
added a commit
that referenced
this pull request
Jan 30, 2025
* tolerations on pre-upgrade-hook job * version bump - changelog --------- Co-authored-by: Ram Mohan Rao Chukka <1331672+chukka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
This PR adds toleration for pre-upgrade-hook job. Without this PR, JFrog can't upgrade itself because
jfrog-platform-pre-upgrade-hookremains inpendingstate when nodes are all tainted.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): n/aSpecial notes for your reviewer:
n/a