Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in Maven and Gradle wrapper config #1034

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix issues in Maven and Gradle wrapper config #1034

merged 2 commits into from
Nov 20, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 15, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Running the jf mvnc command should allow accepting the --use-wrapper value
  • Running the jf mvnc command should ask whether to use the Maven wrapper with (default true)
  • Running the jf gradlec command should ask whether to use the Gradle wrapper with (default true)

@yahavi yahavi added the bug Something isn't working label Nov 15, 2023
@yahavi yahavi requested a review from eyalbe4 November 15, 2023 13:04
@yahavi yahavi self-assigned this Nov 15, 2023
@yahavi yahavi merged commit bc75a5c into jfrog:dev Nov 20, 2023
5 of 8 checks passed
@yahavi yahavi deleted the maven-config branch November 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4