-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate artifactory commands to jfrog-cli-artifactory #1334
Conversation
518b607
to
2c41a1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Leaving most of my review as a comment since it involves unmodified files.
- artifactory/commands/gradle - should be deleted.
- artifactory/commands/testdata - should be deleted.
- Transfer command - I think those should move too, because they belong in the Artifactory repo too, even if they will fall under another team's management. This will also help avoiding the cyclic import which is problematic. Should be moved with the relevant utils in artifactory/commands/utils (precheck, and the transfer named ones)
- The tests directory that was migrated should also be deleted. Then, we can also delete the GitHub workflow if it is redundant.
artifactory/commands/gradle - deleted |
It provides as a wrapping to all unit tests, so we can set a temporary jfrog home directory and set a logger. Let's currently leave this file as long as there are unit tests in this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment, otherwise LGTM!
This pull request depends on the following PR: