Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SAST log messages and update config default root #433

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Oct 15, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

  • Remove leftovers from JasRunners log message and fix an issue where the SAST log message shows undefined for skip-folder
  • When examining the JFrog Applications Config, note that the source_root has an incorrect default value when using debug mode. Essentially, this issue arises in debug mode when a configuration file exists without source_root, leading to the use of the original VSCode extension source code instead of the current project used in debug mode. The underlying cause of this problem can be traced back to the use of __dirname.

@Or-Geva Or-Geva added the ignore for release Automatically generated release notes label Oct 15, 2023
@Or-Geva Or-Geva requested a review from yahavi October 15, 2023 15:29
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Oct 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 15, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Oct 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 15, 2023
@Or-Geva Or-Geva temporarily deployed to frogbot October 15, 2023 15:58 — with GitHub Actions Inactive
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Oct 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 15, 2023
@github-actions
Copy link
Contributor


@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@Or-Geva Or-Geva merged commit 4441383 into jfrog:master Nov 7, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants