Make sure the webview is loaded before sending requests #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or-Geva
added
bug
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Dec 19, 2023
src/main/webview/webviewSidebar.ts
Outdated
| webview.onDidChangeVisibility(() => { | ||
| private async createEventManager(webview: vscode.WebviewView) { | ||
| const eventManager: EventManager = await EventManager.createEventManager(webview.webview, this.connectionManager, this._logManager); | ||
| webview.onDidChangeVisibility(async () => { |
There was a problem hiding this comment.
Let's add it to the context subscriptions to allow cleanup on close:
this.context.subscriptions.push(webview.onDidChangeVisibility...)There was a problem hiding this comment.
Im not sure im getting your point but we have already performed a cleanup at currentWebview.onDidDispose line 28
There was a problem hiding this comment.
I believe that there is a reason that onDidChangeVisibility returns a disposable. Are you sure that currentWebview.onDidDispose disposes of this listener?
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Before this pull request, there was a potential for the Webview to take longer to load than the duration between the IDE sending the first request to the Webview. To address this issue, we now ensure that we wait for a signal indicating the completion of the webview's full loading process before sending any requests.
Dependent on: