Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example URL in connection #79

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Add example URL in connection #79

merged 1 commit into from
Dec 30, 2020

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 2, 2020

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

#78

Instead of showing https://, show an Xray example URL:
image

Same as we did here: jfrog/jfrog-idea-plugin#89

@yahavi yahavi requested a review from eyalbe4 November 2, 2020 18:41
@yahavi yahavi self-assigned this Nov 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@yahavi yahavi marked this pull request as draft December 30, 2020 09:41
@yahavi yahavi marked this pull request as ready for review December 30, 2020 10:52
@yahavi yahavi merged commit a13888e into jfrog:master Dec 30, 2020
@yahavi yahavi deleted the example-url branch December 30, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4