use AST edges for modifier accessors #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a (large) CPG here where the general `.out` is catastrophically slow: 130k calls to `method.isConstructor` took 8 minutes on my machine before, compared to 500ms with this change. I haven't dug deeper but I guess part of this is that methods have a LOT of outgoing CONTAINS edges that are irrelevant for modifiers.
max-leuthaeuser
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a (large) CPG here where the general
.outis catastrophically slow: 130k calls tomethod.isConstructortook 8 minutes on my machine before, compared to 500ms with this change. I haven't dug deeper but I guess part of this is that methods have a LOT of outgoing CONTAINS edges that are irrelevant for modifiers.