[ruby] Move over dataflow tests #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBakerEffendi
approved these changes
May 2, 2024
| @@ -50,6 +50,7 @@ null | |||
| slices.json | |||
| **/.antlr | |||
| /joern-cli/frontends/csharpsrc2cpg/bin | |||
| /joern-cli/frontends/rubysrc2cpg/type_stubs | |||
There was a problem hiding this comment.
I wonder for this rule and the one above, to instead just do
/joern-cli/frontends/*/bin
/joern-cli/frontends/*/type_stubs
There was a problem hiding this comment.
I'll make a note to do this in the next PR, want to merge this one in so long so that I can start on fixing the DF tests.
| sink.reachableByFlows(source).l.size shouldBe 3 | ||
| } | ||
|
|
||
| // Works in deprecated - unable to parse SplattingArgumentIndexingArgument |
There was a problem hiding this comment.
Thanks for the notes. I'll make some issues on the Ruby board for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all of the dataflow tests to the new Ruby frontend from the deprecated one. Ignored the ones that aren't working for now, the next step is to start working on fixing those tests.