[c#] methodFullName for extension method calls #5245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension methods are syntactic sugar that underneath expand to the resolved method call, e.g.
See: Binding Extension Methods at Compile Time
This PR is only a first move towards "full support" (as much as it's feasible) and fixes the
methodFullName
properties of those calls. So, inx.DoStuff()
, it's still a dynamic dispatch call with an argumentx
, but whose fullName is no longerMyClass.DoStuff():<unresolvedSignature>
but ratherMyClassExtensions.DoStuff:void(MyClass)
. I'd like to refactorastForInvocationExpression
a little bit more before piling more stuff into it, as it's quite large as it stands already.