Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c#] cleaning up around "this" and composeMethodFullName #5247

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

xavierpinho
Copy link
Contributor

Making sure we (a) use composeMethodFullName every time we build a methodFullName; (b) use Constants.This.

@xavierpinho xavierpinho added the c# Relates to csharpsrc2cpg label Jan 23, 2025
@xavierpinho
Copy link
Contributor Author

xavierpinho commented Jan 23, 2025

Re-running jobs. Failed on php2cpg, cc @johannescoetzee :

[info] Detecting minified files
[info] - should skip minified files by name correctly
[info] - should skip minified files by content correctly
[info] - should parse all namespaces and move the files to the correct locations *** FAILED ***
[info]   0 was not greater than 0 (PhpDownloadDependenciesTest.scala:86)
[info] a PHP project with dependencies with a non-semver like version
[info] - should resolve and still get all namespaces

@xavierpinho xavierpinho merged commit 16c8afb into master Jan 23, 2025
5 checks passed
@xavierpinho xavierpinho deleted the xavierp/c#-constants-refactor branch January 23, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c# Relates to csharpsrc2cpg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants