More PR comments

jon-wei · Dec 11, 2023 · b169246 · b169246
1 parent 998898e
commit b169246
Showing 1 changed file with 0 additions and 23 deletions.
diff --git a/server/src/main/java/org/apache/druid/catalog/model/Columns.java b/server/src/main/java/org/apache/druid/catalog/model/Columns.java
@@ -20,16 +20,13 @@
 package org.apache.druid.catalog.model;
 
 import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.ImmutableSet;
-import org.apache.druid.java.util.common.IAE;
 import org.apache.druid.java.util.common.StringUtils;
 import org.apache.druid.segment.column.ColumnType;
 import org.apache.druid.segment.column.RowSignature;
 import org.apache.druid.segment.column.ValueType;
 
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 
 public class Columns
 {
@@ -50,11 +47,6 @@ public class Columns
   public static final String SQL_DOUBLE_ARRAY = "DOUBLE ARRAY";
   public static final String SQL_TIMESTAMP = "TIMESTAMP";
 
-  public static final Set<String> NUMERIC_TYPES =
-      ImmutableSet.of(LONG, FLOAT, DOUBLE);
-  public static final Set<String> SCALAR_TYPES =
-      ImmutableSet.of(STRING, LONG, FLOAT, DOUBLE);
-
   public static final Map<String, ColumnType> SQL_TO_DRUID_TYPES =
       new ImmutableMap.Builder<String, ColumnType>()
         .put(SQL_TIMESTAMP, ColumnType.LONG)
@@ -84,11 +76,6 @@ private Columns()
   {
   }
 
-  public static boolean isScalar(String type)
-  {
-    return SCALAR_TYPES.contains(StringUtils.toUpperCase(type.trim()));
-  }
-
   public static ColumnType druidType(ColumnSpec spec)
   {
     if (isTimeColumn(spec.name())) {
@@ -118,16 +105,6 @@ public static String sqlType(ColumnSpec spec)
     return sqlType == null ? druidType.asTypeString() : sqlType;
   }
 
-  public static void validateScalarColumn(String name, String type)
-  {
-    if (type == null) {
-      return;
-    }
-    if (!Columns.isScalar(type)) {
-      throw new IAE("Not a supported Druid type: " + type);
-    }
-  }
-
   public static boolean isTimeColumn(String name)
   {
     return TIME_COLUMN.equals(name);