[fix] Add ssl certs to scratch image #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thanks for this tool, it's awesome and works pretty well!
I wanted to use the docker image just to create a containerized job to export credentials but i found that it was failing to verify the SSL cert. (using -k works)
Looks like the scratch docker image where the go binaries are copied is pretty minimalist and it looks like it doesn't contain the system SSL certs.
I've modified the Dockerfile adding the certificates provided by the
ca-certificates
package from apk and now it looks like it can validate the SSL certificate and establish a secure connection.Thanks again!