Fix: Agents not moving due to FileNotFoundError (original author: @liaopeiyuan)
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwine
approved these changes
Aug 13, 2023
PiotrZak
approved these changes
Aug 14, 2023
| @@ -398,6 +398,9 @@ def start_server(self, int_counter): | |||
| # "persona": {"Klaus Mueller": {"movement": [38, 12]}}, | |||
| # "meta": {curr_time: <datetime>}} | |||
| curr_move_file = f"{sim_folder}/movement/{self.step}.json" | |||
| # if the folder doesn't exist, we create it first. | |||
| if not os.path.exists(os.path.dirname(curr_move_file)): | |||
There was a problem hiding this comment.
Its ok, i get this error, when trying to execute test-simulation.
jackboyla
pushed a commit
to jackboyla/generative_agents
that referenced
this pull request
Dec 14, 2024
Structured Output Revisions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Agents do not move after simulation (e.g.,
run 1) because of the following error:FileNotFoundError: [Errno 2] No such file or directory: '{sim_folder}/movement/0.json'📝 I am submitting this PR to address an error that has been fixed by the original author: @liaopeiyuan.
@liaopeiyuan deserves credit for identifying and resolving the issue. original commit
📝 Initially mentioned here: #5 (comment)