fix: jv_number_value should cache the double value of literal numbers
#3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code of `jv_number_value` is intended to cache the double value of literal numbers, but it does not work because the function accepts the `jv` struct by value. This patch fixes the behavior by checking if the double value is `NaN`, which is the initial value. This patch apparently does not cache the value if the literal is `NaN`, but improves the performance of major use cases; e.g. `range(1000000)` runs 25% faster.
wader
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of
jv_number_valueis intended to cache the double value ofliteral numbers, but it does not work because the function accepts the
jvstruct by value. This patch fixes the behavior by checking if thedouble value is
NaN, which is the initial value. This patch apparentlydoes not cache the value if the literal is
NaN, but improves theperformance of major use cases; e.g.
range(1000000)runs 25% faster.