Skip to content

Commit

Permalink
fix #97: Readonly fields in FormCollections not validated
Browse files Browse the repository at this point in the history
  • Loading branch information
jrief committed Nov 21, 2023
1 parent 5318b05 commit c67571a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion formset/collection.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,16 +233,18 @@ def full_clean(self):
if self.has_many:
self.valid_holders = []
self._errors = ErrorList()
for data in self.data:
for index, data in enumerate(self.data):
if data is None:
continue
initial = self.initial[index] if self.initial and index < len(self.initial) else None
instance = self.retrieve_instance(data)
valid_holders = {}
errors = ErrorDict()
for name, declared_holder in self.declared_holders.items():
if name in data:
holder = declared_holder.replicate(
data=data[name],
initial=initial.get(name, declared_holder.initial) if initial else None,
instance=instance,
ignore_marked_for_removal=self.ignore_marked_for_removal,
)
Expand Down Expand Up @@ -271,6 +273,7 @@ def full_clean(self):
instance = self.retrieve_instance(self.data[name])
holder = declared_holder.replicate(
data=self.data[name],
initial=self.initial.get(name, declared_holder.initial) if self.initial else None,
instance=instance,
ignore_marked_for_removal=self.ignore_marked_for_removal,
)
Expand Down

0 comments on commit c67571a

Please sign in to comment.