Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: Optimize code structure #1218

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Perf: Optimize code structure #1218

merged 1 commit into from
Dec 30, 2024

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Dec 30, 2024

Perf: Optimize code structure

@fit2bot fit2bot requested a review from a team December 30, 2024 10:41
@ZhaoJiSen ZhaoJiSen merged commit 47b7927 into pam Dec 30, 2024
2 of 3 checks passed
@ZhaoJiSen ZhaoJiSen deleted the pr@pam@perf_optimize_code_structure branch December 30, 2024 10:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 30, 2024
View reviewed changes
src/app/pages/pam/pam.component.ts

window.close();
if (iframeWindow) {
iframeWindow.postMessage({ name: "FILE" }, "*");

Check failure

Code scanning / SonarCloud

Origins should be verified during cross-origin communications High

Specify a target origin for this message. See more on SonarQube Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhaoJiSen ZhaoJiSen ZhaoJiSen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fit2bot @ZhaoJiSen