Add positivity validation for line numbers

jvalue · Mar 23, 2023 · bff6d25 · bff6d25
1 parent 1bc5d7f
commit bff6d25
Showing 1 changed file with 21 additions and 0 deletions.
diff --git a/libs/extensions/std/lang/src/text-range-selector-meta-inf.ts b/libs/extensions/std/lang/src/text-range-selector-meta-inf.ts
@@ -1,8 +1,13 @@
+import { strict as assert } from 'assert';
+
 import {
   BlockMetaInformation,
   IOType,
+  PropertyAssignment,
   PropertyValuetype,
+  isNumericLiteral,
 } from '@jvalue/language-server';
+import { ValidationAcceptor } from 'langium';
 
 export class TextRangeSelectorMetaInformation extends BlockMetaInformation {
   constructor() {
@@ -12,10 +17,12 @@ export class TextRangeSelectorMetaInformation extends BlockMetaInformation {
         lineFrom: {
           type: PropertyValuetype.INTEGER,
           defaultValue: 1,
+          validation: greaterThanZeroValidation,
         },
         lineTo: {
           type: PropertyValuetype.INTEGER,
           defaultValue: Number.POSITIVE_INFINITY,
+          validation: greaterThanZeroValidation,
         },
       },
       // Input type:
@@ -27,3 +34,17 @@ export class TextRangeSelectorMetaInformation extends BlockMetaInformation {
     this.docs.description = 'Selects a range of lines from a `TextFile`.';
   }
 }
+
+function greaterThanZeroValidation(
+  property: PropertyAssignment,
+  accept: ValidationAcceptor,
+) {
+  const propertyValue = property.value;
+  assert(isNumericLiteral(propertyValue));
+
+  if (propertyValue.value <= 0) {
+    accept('error', `Line numbers need to be greater than zero`, {
+      node: propertyValue,
+    });
+  }
+}