Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node12 to node16 in action.yml #2221

Merged
merged 4 commits into from
Apr 16, 2023

Conversation

booklearner
Copy link
Contributor

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

This action is already using Node.js v16, but the action.yml file still references v12. This causes a deprecation notice in GitHub Actions:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: kamilkisiela/graphql-inspector@master. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Fixes #2196

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as
appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-inspector/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

Copy link

@wokkaflokka wokkaflokka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azeemchauhan
Copy link

@booklearner I don't have exposure to this code base, but changing Node12-Node16 also would be required to change the internals where it is calling the @action/core method setOutput in order to remove the deprecation warning, here is the quick workaround - actions/toolkit#1218 (comment)

@booklearner
Copy link
Contributor Author

Thanks for the note @azeemchauhan, I believe the setOutput deprecation notice is unrelated to the Node notice. This codebase can/should move away from setOutput by May 2023 but that can be in a separate PR.

cc @kamilkisiela

action.yml Outdated Show resolved Hide resolved
Co-authored-by: Nathan Chapman <nchapman@firstdollar.com>
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023

⚠️ No Changeset found

Latest commit: fa7c1f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nathanchapman
Copy link
Contributor

@kamilkisiela can we please get this merged in?

@Urigo Urigo requested a review from TuvalSimha March 8, 2023 17:27
@TuvalSimha TuvalSimha merged commit 1cff5bb into kamilkisiela:master Apr 16, 2023
@booklearner booklearner deleted the patch-1 branch April 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Action Deprecation notices
6 participants