-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update node12 to node16 in action.yml
#2221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @booklearner @saihaj!
@booklearner I don't have exposure to this code base, but changing Node12-Node16 also would be required to change the internals where it is calling the @action/core method setOutput in order to remove the deprecation warning, here is the quick workaround - actions/toolkit#1218 (comment) |
Thanks for the note @azeemchauhan, I believe the |
Co-authored-by: Nathan Chapman <nchapman@firstdollar.com>
|
@kamilkisiela can we please get this merged in? |
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
This action is already using Node.js v16, but the
action.yml
file still references v12. This causes a deprecation notice in GitHub Actions:Fixes #2196
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as
appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Test Environment:
@graphql-inspector/...
:Checklist:
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...