-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RabbitMQ vhostName
from authParams when declared
#6373
base: main
Are you sure you want to change the base?
Use RabbitMQ vhostName
from authParams when declared
#6373
Conversation
Signed-off-by: Michi U. <4169888+michemache@users.noreply.github.com>
f908127
to
977de43
Compare
Signed-off-by: Michi U. <4169888+michemache@users.noreply.github.com>
252008a
to
83d9508
Compare
/run-e2e rabbitmq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update docs
I have made related update in the doc in this PR kedacore/keda-docs#1525 . @zroubalik @JorTurFer could you help to take a look please 🙏 ? |
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
/run-e2e rabbit |
If the RabbitMQ
vhostName
is declared in theTriggerAuthentication
resource, it will be used.Checklist
Fixes #6369