Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tempo tuning section #830

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Add tempo tuning section #830

merged 11 commits into from
Nov 14, 2024

Conversation

josunect
Copy link
Contributor

@josunect josunect commented Oct 24, 2024 •
edited
Loading

Ref. kiali/kiali#7769

https://deploy-preview-830--kiali.netlify.app/docs/configuration/p8s-jaeger-grafana/tracing/tempo/#tempo-tunning

  • The Grafana documentation has wide guidelines on to improve performance. Is this PR, just a summary of what you can change is added, pointing to the official Grafana docs.
  • Included table of contents

@josunect josunect added the enhancement New feature or request label Oct 24, 2024
@josunect josunect self-assigned this Oct 24, 2024
@josunect josunect changed the title Add tempo tunning section Add tempo tuning section Oct 24, 2024
@josunect josunect mentioned this pull request Oct 24, 2024
Closed
7 tasks
@josunect josunect marked this pull request as ready for review November 13, 2024 14:07
@josunect josunect requested a review from jshaughn November 13, 2024 14:31
jshaughn
jshaughn requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good information, a few recommended edits.

content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md Outdated Show resolved Hide resolved
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md Outdated Show resolved Hide resolved
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md Outdated Show resolved Hide resolved
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md Outdated Show resolved Hide resolved
josunect and others added 4 commits November 14, 2024 06:01
@josunect @jshaughn
Update content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
514c446 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
59e34e4 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
0cdab70 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
b5e06fb 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect josunect requested a review from jshaughn November 14, 2024 06:03
@josunect
Copy link
Contributor Author

Thank you for the review, @jshaughn !

jshaughn
jshaughn approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks @josunect!

@jshaughn jshaughn merged commit ef9d6db into kiali:staging Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@josunect josunect

Labels
enhancement New feature or request
Projects
Kiali Sprint 25-03 | Kiali v2.6
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josunect @jshaughn