PR for #307 #308
Open
PR for #307 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small edits that make feature request in #307 possible. First,
find_mod.box$pkg_specwill try and search for the package eagerly to see if it exists. Otherwise it assumes it is really a module. A small edit has been made tomod_file_candidates()switching out the basefile.pathfor internal functionfile_pathwhich removes zero length arguments. zero length arguments infile.pathwill cause the function to return a zero length character vector. This allowsfind_global_modto find a mod that is pkg like and does not have a prefix attribute.