[release-1.12] Surface cpu and mem requests forbidden errors (and other ones too) in KSVC creation #14618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…there is something wrong (like low resources request and limits), since it was just beign propagated when the revision status was nil and the deployment existed trying to surface replicaset creation errors
…not nil after the revision is created
…can have Ready Inactive Revisions (scale to zero) * added docs and tests for this and the replicaset failure propagation
…, improved propagation logic + left todos regarding revision conditionset
…t failing to create
…and it fails fast, so removing the bits where it can go one way or another in the e2e resource_quota_error_test
… revision table test
… service creation test
… error so adding that case too
knative-prow
bot
added
area/test-and-release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #14618 +/- ##
=============================================
Coverage 86.02% 86.02%
=============================================
Files 197 197
Lines 14916 14922 +6
=============================================
+ Hits 12831 12837 +6
Misses 1776 1776
Partials 309 309
☔ View full report in Codecov by Sentry. |
psschwei
approved these changes
Nov 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, psschwei, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #14453