Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Removal of vendor and third-party license dirs #29

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Apr 11, 2024

Changes

  • 🧹 Removal of vendor and third-party license dirs

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 11, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2024
@cardil cardil changed the title 🧹 Removal of vendor dir 🧹 Removal of vendor and third-party licenses dirs Apr 11, 2024
@cardil cardil changed the title 🧹 Removal of vendor and third-party licenses dirs 🧹 Removal of vendor and third-party license dirs Apr 11, 2024
@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

Review dog is failing some checks because the of how big the diff is

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
Copy link

knative-prow bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/override Do Not Submit
/override style / Golang / Do Not Submit

Copy link

knative-prow bot commented Apr 11, 2024

@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /
  • Do
  • Golang
  • Not
  • Submit
  • style

Only the following failed contexts/checkruns were expected:

  • Do Not Submit
  • EasyCLA
  • build-tests_toolbox_main
  • style / Golang / Do Not Submit
  • style / Golang / Lint
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_toolbox_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Do Not Submit
/override style / Golang / Do Not Submit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/override Do Not Submit

Copy link

knative-prow bot commented Apr 11, 2024

@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Do
  • Not
  • Submit

Only the following failed contexts/checkruns were expected:

  • Do Not Submit
  • EasyCLA
  • build-tests_toolbox_main
  • style / Golang / Do Not Submit
  • style / Golang / Lint
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_toolbox_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Do Not Submit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/override style / Golang / Lint

Copy link

knative-prow bot commented Apr 11, 2024

@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /
  • Golang
  • Lint
  • style

Only the following failed contexts/checkruns were expected:

  • Do Not Submit
  • EasyCLA
  • build-tests_toolbox_main
  • style / Golang / Do Not Submit
  • style / Golang / Lint
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_toolbox_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override style / Golang / Lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/override "Do Not Submit"

Copy link

knative-prow bot commented Apr 11, 2024

@cardil: Overrode contexts on behalf of cardil: Do Not Submit

In response to this:

/override "Do Not Submit"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/override "style / Golang / Do Not Submit"

Copy link

knative-prow bot commented Apr 11, 2024

@cardil: Overrode contexts on behalf of cardil: style / Golang / Do Not Submit

In response to this:

/override "style / Golang / Do Not Submit"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/override "style / Golang / Lint"
/override "style / suggester / shell"

Copy link

knative-prow bot commented Apr 11, 2024

@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint, style / suggester / shell

In response to this:

/override "style / Golang / Lint"
/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
Copy link
Contributor Author

cardil commented Apr 11, 2024

/override "style / suggester / yaml"

Copy link

knative-prow bot commented Apr 11, 2024

@cardil: Overrode contexts on behalf of cardil: style / suggester / yaml

In response to this:

/override "style / suggester / yaml"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 9c3eea8 into knative:main Apr 11, 2024
23 of 28 checks passed
@cardil cardil deleted the chore/remove-vendor branch April 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants