✨ (go/v4): add race flag for go test command at the makefile

[PG2000]

In order to detect data races early it would make sense to use the race flag
for the most common generated go commands.

In grown projects built on kubebuilder i observed that with the timing and growing codebases
some data races occured in tests and then its hard to find the causing commit or code chnage.

Maybe this change can help to find them earlier.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PG2000
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @PG2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

/ok-to-test

IMHO, this is a great thought!

However, please note that whenever we update the scaffold, we need to run make generate to regenerate all samples under testdata and in the docs/book.

Additionally, I hope you don’t mind, but I updated the title of this PR to include an emoji so it aligns with our standards and helps us create the Release Notes. Please refer to the CONTRIBUTING.md guide for more details.

Could you please:

Run make generate locally, commit the changes, and squash them to ensure this PR has only one commit? That way, we can proceed to merge it once the CI checks pass.

Thank you! 🙌

[camilamacedo86]

Also, see that the changes here broke the tests

      #15 [builder 9/9] RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -race -a -o manager cmd/main.go
      #15 0.430 go: -race requires cgo; enable cgo by setting CGO_ENABLED=1
      #15 ERROR: process "/bin/sh -c CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -race -a -o manager cmd/main.go" did not complete successfully: exit code: 2
      ------

It does not seems to work.
So, can you please check out?

[PG2000]

Will check this. Seems like CGO must be enabled for go build. Will try to leave this part out and start on the other problem where a data race was detected.

[k8s-ci-robot]

@PG2000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-e2e-k8s-1-32-0	51115f7	link	true	/test pull-kubebuilder-e2e-k8s-1-32-0
pull-kubebuilder-e2e-k8s-1-30-8	51115f7	link	true	/test pull-kubebuilder-e2e-k8s-1-30-8

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dmvolod]

This slow-down all process for several times and required cgo to be enabled, and on non-Darwin systems requires an installed C compiler. Not sure, it should be enabled by default.

Probably it can be an option or flag and customer should decide if it enabled or not.
For example, we are using it for long running CI processes at night, but not in regular pipelines for each PR.

[dmvolod]

If we want to add some extra flexibility, we can introduce a field that will be empty by default with the ability to change it, and which we will add as arguments when calling tests and/or build.
We can add two different fields for build and tests.
But it is very dangerous to forcefully add the -race flag by default.