Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: fix missing kicbase in release #20291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −10
Open

release: fix missing kicbase in release #20291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions hack/jenkins/release_build_and_upload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,7 @@ cp "out/minikube-${RPM_VERSION}-0.armv7hl.rpm" out/minikube-latest.armv7hl.rpm
cp "out/minikube-${RPM_VERSION}-0.ppc64le.rpm" out/minikube-latest.ppc64le.rpm
cp "out/minikube-${RPM_VERSION}-0.s390x.rpm" out/minikube-latest.s390x.rpm

gsutil -m cp out/* "gs://$BUCKET/releases/$TAGNAME/"

# Update "latest" release for non-beta/non-alpha builds
if ! [[ ${VERSION_BUILD} =~ ^[0-9]+$ ]]; then
echo "NOTE: ${VERSION} appears to be a non-standard release, not updating /releases/latest"
exit 0
fi

#echo "Updating Docker images ..."
#make push-gvisor-addon-image push-storage-provisioner-manifest

echo "Generating tarballs for kicbase images"
# first get the correct tag of the kic base image
Expand All @@ -136,5 +127,19 @@ do
docker rmi -f ${IMAGE_NAME}
done


# upload to google bucket
gsutil -m cp out/* "gs://$BUCKET/releases/$TAGNAME/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might be things in out folder that we dont want ? maybe like Linters binaries or somethign like that ? and why this is added to this PR? before this PR we didnt have artifacts in the GCS bucket?


# Update "latest" release for non-beta/non-alpha builds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ComradeProgrammer is this releated to this PR or is this something generally fixing ? what is exactly doing?

if ! [[ ${VERSION_BUILD} =~ ^[0-9]+$ ]]; then
echo "NOTE: ${VERSION} appears to be a non-standard release, not updating /releases/latest"
exit 0
fi

#echo "Updating Docker images ..."
#make push-gvisor-addon-image push-storage-provisioner-manifest


echo "Updating latest bucket for ${VERSION} release ..."
gsutil cp -r "gs://${BUCKET}/releases/${TAGNAME}/*" "gs://${BUCKET}/releases/latest/"
2 changes: 1 addition & 1 deletion hack/jenkins/release_github_page.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ for path in $(gsutil ls "gs://${ISO_BUCKET}/minikube-v${VERSION}*" || true); do
done

# Upload all end-user assets other than preload files, as they are release independent
for file in $( find out \( -name "minikube[_-]*" -or -name "docker-machine-*" \) ); do
for file in $( find out \( -name "minikube[_-]*" -or -name "docker-machine-*" -or -name "kic*" \) ); do
n=0
until [ $n -ge 5 ]
do
Expand Down