Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon headlamp: Update headlamp-k8s/headlamp image from v0.26.0 to v0.28.0 #20311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaquimrocha
Copy link
Contributor

Upgrade Headlamp version to 0.28.0
cc: @joaquimrocha

….28.0

Signed-off-by: joaquimrocha <joaquimrocha@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot requested a review from medyagh January 23, 2025 18:47
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joaquimrocha
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Jan 23, 2025

@joaquimrocha would you be ineterested to add this as an auto-updater simmilar to other addons to be making this PR automatically in github action ? checkout our github action for other addons

@medyagh
Copy link
Member

medyagh commented Jan 23, 2025

#20100 (comment)

@joaquimrocha
Copy link
Contributor Author

#20100 (comment)

Just replied to your comment. Sorry again for the delay.
I think that we can move on faster with the automation, but it's maybe worth merging this one now, since I realized that the 0.27.0 has not been merged. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants