Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old TestGrid config upload job. #33157

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

michelle192837
Copy link
Contributor

The new upload job (post-test-infra-upload-testgrid-config-canary, https://testgrid.k8s.io/sig-testing-maintenance#testgrid-config-update-canary) is working and TestGrid's config-merger is successfully pulling it in canary, so the old one shouldn't be needed anymore.

/hold

I want to let this soak for a bit in the production config-merger (until I verify it works a couple times).

Ref #32432

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and upodroid July 30, 2024 17:50
@ameukam
Copy link
Member

ameukam commented Jul 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@michelle192837
Copy link
Contributor Author

michelle192837 commented Jul 30, 2024

Config merging has succeeded in prod! Let's see how it goes...

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5778e78 into kubernetes:master Jul 30, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@michelle192837: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

The new upload job (post-test-infra-upload-testgrid-config-canary, https://testgrid.k8s.io/sig-testing-maintenance#testgrid-config-update-canary) is working and TestGrid's config-merger is successfully pulling it in canary, so the old one shouldn't be needed anymore.

/hold

I want to let this soak for a bit in the production config-merger (until I verify it works a couple times).

Ref #32432

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michelle192837 michelle192837 deleted the deletetgupload branch July 30, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants