-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calculate percentiles using different library (montanaflynn/stats) #3086
feat: calculate percentiles using different library (montanaflynn/stats) #3086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, always excited to see new tests added! 👍
@scott-david-walker check unit tests and run go fmt for your changes |
Could someone give me advice on what's going on with the linting error?
Apologies if this is a stupid question, bit of a noob at GoLang :-) |
@scott-david-walker make sure your code is go formatted. in other case, it could be github caching issue |
Codecov ReportBase: 18.75% // Head: 18.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
==========================================
+ Coverage 18.75% 18.97% +0.22%
==========================================
Files 206 206
Lines 15233 15239 +6
==========================================
+ Hits 2857 2892 +35
+ Misses 12174 12141 -33
- Partials 202 206 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@scott-david-walker ignore linting check, just solve merging issue. it should be enough for merging |
# Conflicts: # pkg/repository/common/metrics_test.go
Pull request description
Checklist (choose whats happened)
Breaking changes
Changes
Fixes