Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate percentiles using different library (montanaflynn/stats) #3086

Merged
merged 6 commits into from
Jan 24, 2023

Conversation

scott-david-walker
Copy link
Contributor

@scott-david-walker scott-david-walker commented Jan 23, 2023

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

  • Use new library to calculate percentiles (montanaflynn/stats)
  • Added unit tests

Fixes

Copy link
Contributor

@vLia vLia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, always excited to see new tests added! 👍

@vsukhin
Copy link
Collaborator

vsukhin commented Jan 23, 2023

@scott-david-walker check unit tests
--- FAIL: TestTestExecutionsMetrics/getting_percentiles_of_execution_duration (0.00s)
FAIL
FAIL

and run go fmt for your changes

@scott-david-walker
Copy link
Contributor Author

Could someone give me advice on what's going on with the linting error?

Cannot open: File exists in this action
I've ran the gofmt commands so I'm at a bit of a loss

Apologies if this is a stupid question, bit of a noob at GoLang :-)

@vsukhin
Copy link
Collaborator

vsukhin commented Jan 24, 2023

@scott-david-walker make sure your code is go formatted. in other case, it could be github caching issue

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Base: 18.75% // Head: 18.97% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (451ba5e) compared to base (5704467).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
+ Coverage   18.75%   18.97%   +0.22%     
==========================================
  Files         206      206              
  Lines       15233    15239       +6     
==========================================
+ Hits         2857     2892      +35     
+ Misses      12174    12141      -33     
- Partials      202      206       +4     
Impacted Files Coverage Δ
pkg/repository/common/metrics.go 88.63% <100.00%> (+88.63%) ⬆️
pkg/api/v1/client/common.go 82.14% <0.00%> (-7.15%) ⬇️
pkg/agent/events.go 51.85% <0.00%> (-2.47%) ⬇️
pkg/cloud/service_grpc.pb.go 45.97% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vsukhin
Copy link
Collaborator

vsukhin commented Jan 24, 2023

@scott-david-walker ignore linting check, just solve merging issue. it should be enough for merging

# Conflicts:
#	pkg/repository/common/metrics_test.go
@vsukhin vsukhin merged commit c93d60d into kubeshop:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants