Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added as203105 to bird config #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

flimpie
Copy link

@flimpie flimpie commented Nov 14, 2023

No description provided.

@esmil esmil requested a review from Hafpaf November 28, 2023 20:53
@esmil
Copy link
Member

esmil commented Nov 28, 2023

Hey, sorry about the late review. I'm not good at bird, but the changes look fine to me. I guess you know what ttl security means which I think is the only difference for the other entries.

I will request that you fix your commit message so it matches the pattern you'll see if you do
git log roles/space_server/files/bird.conf

@alloverallover
Copy link
Contributor

@esmil Please start doing these trivial formatting changes yourself. It is very little work and will help people around you. As you can see these petty rules leave otherwise complete pull requests hanging for months.

I changed the commit message and made a new pull request. Please merge #62 and close this PR.

Copy link
Collaborator

@Hafpaf Hafpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Valid BIRD config.
Please contact me in case TTL security kills your BGP sessions.

@esmil TTL security (RFC 5082) checks whether that point-to-point routers are directly connected to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants