Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: Make BaseRetriever generic and pass Metadata type to DocumentInterface #4568

Merged
merged 2 commits into from
Feb 29, 2024
Merged

core[patch]: Make BaseRetriever generic and pass Metadata type to DocumentInterface #4568

merged 2 commits into from
Feb 29, 2024

Conversation

davidfant
Copy link
Contributor

@davidfant davidfant commented Feb 28, 2024 •
edited
Loading

Fixes #4510

X: @da_fant

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 28, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 2:32am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Feb 29, 2024 2:32am

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Feb 28, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Feb 29, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 changed the title Make BaseRetriever generic and pass Metadata type to DocumentInterface core[patch]: Make BaseRetriever generic and pass Metadata type to DocumentInterface Feb 29, 2024
@jacoblee93 jacoblee93 merged commit 11a617d into langchain-ai:main Feb 29, 2024
23 checks passed
@davidfant davidfant mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make BaseRetriever generic and pass Metadata type to DocumentInterface
2 participants
@davidfant @jacoblee93