Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Interia based useForm return types #55

Closed
wants to merge 2 commits into from
Closed

Fix Interia based useForm return types #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30cf0f0
Fix Interia based useForm return types
Spice-King Nov 22, 2023
6f6bf0f
Make inertiaForm's more complex for TS to avoid TS4032
Spice-King Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-inertia/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { useRef } from 'react'

export { client }

export const useForm = <Data extends Record<string, unknown>>(method: RequestMethod|(() => RequestMethod), url: string|(() => string), inputs: Data, config: ValidationConfig = {}): any => {
export const useForm = <Data extends Record<string, unknown>>(method: RequestMethod|(() => RequestMethod), url: string|(() => string), inputs: Data, config: ValidationConfig = {}) => {
const booted = useRef<boolean>(false)

/**
Expand Down
5 changes: 3 additions & 2 deletions packages/vue-inertia/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ import { watchEffect } from 'vue'

export { client }

export const useForm = <Data extends Record<string, unknown>>(method: RequestMethod|(() => RequestMethod), url: string|(() => string), inputs: Data, config: ValidationConfig = {}): any => {
export const useForm = <Data extends Record<string, unknown>>(method: RequestMethod|(() => RequestMethod), url: string|(() => string), inputs: Data, config: ValidationConfig = {}) => {
/**
* The Inertia form.
*/
const inertiaForm = useInertiaForm(inputs)
const inertiaForm = useInertiaForm(inputs) as Omit<ReturnType<typeof useInertiaForm<Data>>, never>
// typecast can be removed/reverted when inertiajs/inertia#1734 is merged and released, tricks TS to not care for now by making it a more complex type.

/**
* The Precognitive form.
Expand Down