Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Products page. #5097

Closed
wants to merge 8 commits into from
Closed

Conversation

Modern-artist
Copy link
Contributor

Description
Final Products page.

This PR fixes #
Implemented Final Product page.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Modern-artist <90668597+Modern-artist@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Nov 2, 2023

🚀 Preview for commit 112e4b1 at: https://6543202a8fec0a04d411d398--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Hey @Modern-artist Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

Signed-off-by: Modern-artist <90668597+Modern-artist@users.noreply.github.com>
Signed-off-by: Prem kumar <90668597+Modern-artist@users.noreply.github.com>
Signed-off-by: Prem kumar <90668597+Modern-artist@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Nov 6, 2023

🚀 Preview for commit 18c6c41 at: https://6548c4b886d5720cb35882e8--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

Please add this as your agenda in Doc to present it in the Website Meet today at 6:30 pm IST/7:00 am CT

Copy link
Member

@ankushbhardwaj408 ankushbhardwaj408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we hover over product link in navbar the whole screen turns white

@abhijeetgauravm
Copy link
Contributor

When we hover over product link in navbar the whole screen turns white

Yeah @ankushbhardwaj408 // @Modern-artist

@leecalcote leecalcote requested a review from Mohith234 November 7, 2023 13:05
@l5io
Copy link
Contributor

l5io commented Nov 8, 2023

🚀 Preview for commit a1173fe at: https://654bacd913188767397f3dbc--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

When we hover over product link in navbar the whole screen turns white

@Modern-artist

@leecalcote
Copy link
Member

@Modern-artist, it means that you have a bug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images should be colocated in the same components in which they are used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG contains a number of PNGs and is not usable. Ensure only vector contents is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG contains a number of PNGs and is not usable. Ensure only vector contents is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image and other images here are really just PNGs and cannot be used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relocate this image.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this logo in this site's general assets. Reuse.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a PNG.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this logo in this site's general assets. Reuse.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like other pages, this page should be in sections and contain both sections and components.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG contains a number of PNGs and is not usable. Ensure only vector contents is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG contains a number of PNGs and is not usable. Ensure only vector contents is used.

Don't duplicate the logo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG contains a number of PNGs and is not usable. Ensure only vector contents is used.

Don't duplicate.

@@ -0,0 +1,569 @@
import styled from "styled-components";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A complete copy/paste? We're increasing our sustaining costs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change, so don't include this file.

@leecalcote
Copy link
Member

Most of the buttons included here don't work, @Modern-artist.

This PR is not ready for review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote
Copy link
Member

The length of the CSS file needs cut down (by ~1/2)

@l5io
Copy link
Contributor

l5io commented Nov 11, 2023

🚀 Preview for commit 449a447 at: https://654ef96c7dbdf35abc87e3ef--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Hey @Modern-artist Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@leecalcote
Copy link
Member

@Modern-artist are we pressing forward here or closing out and starting over?

@Modern-artist
Copy link
Contributor Author

@Modern-artist are we pressing forward here or closing out and starting over?

I would prefer to start again as I haven't written any code for the first two sections.

@leecalcote leecalcote closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants