Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: possibility to create a koson array from a collection #5

Conversation

achatellier
Copy link
Contributor

... and fix tests on windows

@achatellier
Copy link
Contributor Author

Regarding the line separator, I understand the need to select the right separator when koson produce some data.
But when processing data from the outside world, koson cannot make assumption about the separator used in strings.

Copy link
Collaborator

@ncomet ncomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put some annotations on the files with suggestions, then we can merge ! Thanks !

src/main/kotlin/com/lectra/koson/Koson.kt Outdated Show resolved Hide resolved
src/test/kotlin/com/lectra/koson/KosonTest.kt Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@795fdd4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master      #5   +/-   ##
========================================
  Coverage          ?   94.8%           
  Complexity        ?      13           
========================================
  Files             ?       1           
  Lines             ?      77           
  Branches          ?      11           
========================================
  Hits              ?      73           
  Misses            ?       2           
  Partials          ?       2
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/com/lectra/koson/Koson.kt 94.8% <100%> (ø) 13 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795fdd4...55ecd77. Read the comment docs.

@ncomet ncomet merged commit c2ba42f into lectra-tech:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants