Improve SDL_config_unix.h #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is believed to be a predefined macro on all reasonable Unix platforms in practice (it's certainly predefined on GNU/Linux). We can add some `|| defined(__myplatform__)` as necessary, but this way is more readable than listing every Unix we know about individually. https://sourceforge.net/p/predef/wiki/OperatingSystems/ notes that "the xlC or the DEC C/C++ compiler" don't define these, but that doesn't seem likely to have any practical impact on us. Signed-off-by: Simon McVittie <smcv@collabora.com>
SDL_config_minimal.h is rather minimal, and we probably don't want anyone to actually be relying on it. Signed-off-by: Simon McVittie <smcv@collabora.com>
Some of these are Standard C, some are POSIX, and a few are non-standard but widely available. Signed-off-by: Simon McVittie <smcv@collabora.com>
The gcc atomic operations are a gcc-specific extension, which clang implements for compatibility. In the unlikely event that someone compiles sdl2-compat with some other compiler, we can't assume their presence. Signed-off-by: Simon McVittie <smcv@collabora.com>
gcc (and presumably clang) predefines this, and if present, it seems reasonable to treat it as authoritative. Signed-off-by: Simon McVittie <smcv@collabora.com>
sezero
reviewed
Feb 4, 2025
| @@ -51,6 +51,7 @@ | |||
| #include "SDL_config_unix.h" | |||
| #else | |||
| /* This is a minimal configuration just to get SDL running on new platforms. */ | |||
| #warning SDL_config.h might be incomplete, good luck | |||
There was a problem hiding this comment.
Is #warning directive universally supported? A #pragma message("...") may also be considered here.
There was a problem hiding this comment.
I believe #warning is more widely supported than #pragma message()
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL_config.h: Assume that Unix platforms define
__unix__This is believed to be a predefined macro on all reasonable Unix
platforms in practice (it's certainly predefined on GNU/Linux).
We can add some
|| defined(__myplatform__)as necessary, butthis way is more readable than listing every Unix we know about
individually.
https://sourceforge.net/p/predef/wiki/OperatingSystems/ notes that
"the xlC or the DEC C/C++ compiler" don't define these, but that doesn't
seem likely to have any practical impact on us.
SDL_config.h: Add a #warning if we don't recognise the platform
SDL_config_minimal.h is rather minimal, and we probably don't want anyone
to actually be relying on it.
SDL_config_unix.h: Describe our basis for assuming that headers exist
Some of these are Standard C, some are POSIX, and a few are non-standard
but widely available.
SDL_config_unix.h: Only define HAVE_GCC_ATOMICS for gcc or clang
The gcc atomic operations are a gcc-specific extension, which clang
implements for compatibility. In the unlikely event that someone compiles
sdl2-compat with some other compiler, we can't assume their presence.
SDL_config_unix.h: Try to use
__SIZEOF_POINTER__, if definedgcc (and presumably clang) predefines this, and if present, it seems
reasonable to treat it as authoritative.
As discussed in #229. Compiles successfully on my Debian system, otherwise untested.