-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jan 2025 Improvements #97
base: master
Are you sure you want to change the base?
Conversation
For some reason I'm still permitted to see these PRs and could accept it. Maybe my account needs to be removed from some authorization? Happy New Year! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're modifying those, should we prefix the tweet routes with /api
to be consistent with what we tell them in the future? Also, we should modify the POST
route so it returns the tweet obj, instead of making them refetch the entire tweets[] for good practice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I like moving to
/api
for consistency. - We have an assignment Refetch Tweets on Submission that would have to be updated as well if we change what the server returns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the activity would need to match, but doesn't seem like too much of an update no?
Changes:
/api