WebGL #312
WebGL #312
Conversation
|
@pema99 I only really need you to look at these changes |
Packages/com.llealloo.audiolink/Runtime/Materials/mat_AudioLink.mat
Outdated
Show resolved
Hide resolved
Packages/com.llealloo.audiolink/Runtime/Materials/mat_AudioLinkControllerScreenMaterial.mat
Outdated
Show resolved
Hide resolved
| @@ -210,6 +214,25 @@ public partial class AudioLink : MonoBehaviour | |||
| private int _Samples3R; | |||
| // ReSharper restore InconsistentNaming | |||
|
|
|||
| #if UNITY_WEBGL | |||
There was a problem hiding this comment.
This file is already pretty crowded. Consider moving the WebGL specific stuff to a new file, like we do for the DataAPI already - AudioLink is a partial class
There was a problem hiding this comment.
do we have to? is this blocking?
There was a problem hiding this comment.
not blocking, but i think it would be nicer. Consider for a follow up
Packages/com.llealloo.audiolink/Runtime/Scripts/AudioLinkController.cs
Outdated
Show resolved
Hide resolved
| return _waveformSamplesRight; | ||
| } | ||
|
|
||
| public void SyncLeft(Action<float[]> FetchSamplesLeft) |
There was a problem hiding this comment.
why not just regular setters?
There was a problem hiding this comment.
idk I think fundale wrote that
There was a problem hiding this comment.
maybe change it? looks like a simple change to make
There was a problem hiding this comment.
@fundale any reason you wrote it like this?
There was a problem hiding this comment.
@fundale any reason you wrote it like this?
Not particularly,
A setter might work, I just did it the same way as this shim:
https://github.com/Lakistein/Unity-Audio-Visualizers
There was a problem hiding this comment.
hmmm i tried today, my attempt didn't work ce64511, i'm confused about how the this syntax works
There was a problem hiding this comment.
if (audioSource.isPlaying)
{
audioLinkWebPeer.WaveformSamplesLeft = FetchAnalyzerLeft(WebALID, new float[4096], 4096);
audioLinkWebPeer.WaveformSamplesRight = FetchAnalyzerRight(WebALID, new float[4096], 4096);
}
Should probably be
if (audioSource.isPlaying)
{
FetchAnalyzerLeft(WebALID, audioLinkWebPeer.WaveformSamplesLeft, 4096);
FetchAnalyzerRight(WebALID, audioLinkWebPeer.WaveformSamplesRight, 4096);
}
|
@float3 left some comments. Sorry it took so long |
|
Still wanna land this? There are a bunch of open comments |
|
@pema99 this branch is kinda horrible |
|
should we just land this and do some clean up on dev, I lowkey don't wanna redo all these changes for a new PR, especially since I want fundale to have attribution |
|
but I kinda fucked it up |
No description provided.