Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR] Cleanup cir.scopes with a single cir.yield operation #1291

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

AmrDeveloper
Copy link
Member

Cleanup cir scope if it contains only yield operation

Fixes: #455

Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes
Copy link
Member

We just went over a rebase against upstream, apologies for the churn but please update your branch for this PR and force-push!

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks! Some tests fail because of the rebase churn, not related to this PR.

@bcardosolopes bcardosolopes merged commit 34bd74e into llvm:main Jan 29, 2025
3 of 6 checks passed
AmrDeveloper added a commit to AmrDeveloper/clangir that referenced this pull request Jan 29, 2025
Cleanup cir scope if it contains only yield operation

Fixes: llvm#455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup cir.scopes with a single cir.yield operation
3 participants